Path validation: builder/verifier API skeletons #9405

woodruffw · 2023-08-11T19:18:18Z

This breaks out #8873, including everything except the top-level verify APIs (both Python and Rust).

Signed-off-by: William Woodruff <[email protected]> validation: remove Profile abstract from public APIs One step towards removing it entirely Signed-off-by: William Woodruff <[email protected]> policy: disambiguate references Signed-off-by: William Woodruff <[email protected]> policy: remove separate rfc5280 profile Signed-off-by: William Woodruff <[email protected]> policy: remove profile abstraction entirely Signed-off-by: William Woodruff <[email protected]> rust: permitted_algorithms filtering Signed-off-by: William Woodruff <[email protected]> verify: simplify policy API substantially No more manual monomorphization. Signed-off-by: William Woodruff <[email protected]> src, tests: remove verification code Signed-off-by: William Woodruff <[email protected]> validation: remove more validation code Signed-off-by: William Woodruff <[email protected]>

Signed-off-by: William Woodruff <[email protected]>

alex · 2023-08-14T01:43:36Z

I think we're going to want to break this down even further: basically take each type in the public API, and put that into its own PR.

Signed-off-by: William Woodruff <[email protected]>

woodruffw · 2023-08-14T09:40:58Z

I think we're going to want to break this down even further: basically take each type in the public API, and put that into its own PR.

Opened #9411 for just the Store bits; I'll do the same for others.

Breakout from pyca#9405. Signed-off-by: William Woodruff <[email protected]>

Breakout from #9405. Signed-off-by: William Woodruff <[email protected]>

Signed-off-by: William Woodruff <[email protected]>

woodruffw · 2023-09-08T14:33:55Z

Just to keep things synchronized here: this is blocked on #9548; once that's merged, we can deconflict here and determine what (if anything else) needs to be split out to get this to a reviewable size.

Signed-off-by: William Woodruff <[email protected]>

Not used, yet. Signed-off-by: William Woodruff <[email protected]>

This reverts commit a5154e1.

Paring down for review. Signed-off-by: William Woodruff <[email protected]>

Signed-off-by: William Woodruff <[email protected]>

For now. Signed-off-by: William Woodruff <[email protected]>

Signed-off-by: William Woodruff <[email protected]>

src/rust/cryptography-x509-validation/Cargo.toml

src/rust/cryptography-x509-validation/src/policy/mod.rs

src/rust/src/x509/verify.rs

Signed-off-by: William Woodruff <[email protected]>

Since it doesn't actually do anything WebPKI related at the moment. Signed-off-by: William Woodruff <[email protected]>

woodruffw · 2023-09-16T20:05:57Z

src/rust/src/types.rs

@@ -201,7 +201,6 @@ pub static UNRECOGNIZED_EXTENSION: LazyPyImport =
    LazyPyImport::new("cryptography.x509", &["UnrecognizedExtension"]);
 pub static EXTENSION: LazyPyImport = LazyPyImport::new("cryptography.x509", &["Extension"]);
 pub static EXTENSIONS: LazyPyImport = LazyPyImport::new("cryptography.x509", &["Extensions"]);
-pub static IPADDRESS: LazyPyImport = LazyPyImport::new("cryptography.x509", &["IPAddress"]);


NB: I moved this down and renamed it to make it consistent with DNS_NAME + co-locate it with the other exported name types (DNS_NAME and RFC822_NAME).

alex · 2023-09-16T20:05:25Z

docs/x509/verification.rst

+
+        The verifier's validation time. If not specified during construction
+        (see :class:`PolicyBuilder`), this is set to
+        :meth:`datetime.datetime.now`.


The if not specified should go in the policy builder docs, and should state that it's now at the time you call build

alex · 2023-09-16T20:06:27Z

src/rust/src/x509/verify.rs

@@ -43,6 +47,125 @@ impl CryptoOps for PyCryptoOps {
    }
 }

+struct FixedPolicy<'a>(Policy<'a, PyCryptoOps>);


Is there a better name than FixedPolicy?

Hmm, maybe BoundPolicy (to emphasize that we're binding a Policy to its PyCryptoOps? Or maybe I could just import Policy as _Policy or similar and rename this to Policy.

How about PyCryptoPolicy :-)

alex · 2023-09-16T20:07:50Z

src/rust/src/x509/verify.rs

+    // TODO: Switch this to `Py<PyString>` once Pyo3's `to_str()` preserves a
+    // lifetime relationship between an a `PyString` and its borrowed `&str`
+    // reference in all limited API builds. PyO3 can't currently do that in
+    // older limited API builds because it needs `PyUnicode_AsUTF8AndSize` to do
+    // so, which was only stabilized with 3.10.


Doesn't need to block this, but would be good to send a PR that implements the method for Python >= 3.10.

alex · 2023-09-16T20:09:20Z

src/rust/src/x509/verify.rs

+    DNSName((pyo3::Py<pyo3::PyAny>, String)),
+    IPAddress((pyo3::Py<pyo3::PyAny>, pyo3::Py<pyo3::types::PyBytes>)),


I think it'd be marginally cleaner if there was a seperate py_subject field on the Verifier, and then SubjectOwner's enum elements only needed to be a single field.

src/rust/src/x509/verify.rs

Signed-off-by: William Woodruff <[email protected]>

alex · 2023-09-16T20:42:41Z

src/rust/src/x509/verify.rs

+    // TODO: Switch this to `Py<PyString>` once Pyo3's `to_str()` preserves a
+    // lifetime relationship between an a `PyString` and its borrowed `&str`
+    // reference in all limited API builds. PyO3 can't currently do that in
+    // older limited API builds because it needs `PyUnicode_AsUTF8AndSize` to do
+    // so, which was only stabilized with 3.10.


Pretty sure this goes in SubjectOwner?

Yep, bad copy. Thanks.

alex · 2023-09-16T20:43:24Z

src/rust/src/x509/verify.rs

+    // reference in all limited API builds. PyO3 can't currently do that in
+    // older limited API builds because it needs `PyUnicode_AsUTF8AndSize` to do
+    // so, which was only stabilized with 3.10.
+    py_subject: pyo3::Py<pyo3::PyAny>,


You can use pyo3(get, name = "subject") here (https://pyo3.rs/v0.19.2/class#object-properties-using-pyo3get-set)

Signed-off-by: William Woodruff <[email protected]>

woodruffw force-pushed the tob-x509-api-breakout branch from 0b085cd to 36fef28 Compare August 11, 2023 19:19

woodruffw added 4 commits August 13, 2023 15:06

cryptography, rust: lintage

e4e300f

Signed-off-by: William Woodruff <[email protected]>

Merge branch 'main' into tob-x509-api-breakout

35a4e28

cryptography, rust: lintage, add Policy.subject API

bb76afe

Signed-off-by: William Woodruff <[email protected]>

src, tests: initial PolicyBuilder tests

3a67770

Signed-off-by: William Woodruff <[email protected]>

woodruffw added 4 commits August 14, 2023 10:25

verify: Policy.validation_time getter

6cabf0d

Signed-off-by: William Woodruff <[email protected]>

push Store into rust

8157ce4

Signed-off-by: William Woodruff <[email protected]>

cleanup, fixup

5a69a28

Signed-off-by: William Woodruff <[email protected]>

Merge remote-tracking branch 'upstream/main' into tob-x509-api-breakout

539a7b2

woodruffw mentioned this pull request Aug 14, 2023

x509: add Store API #9411

Merged

woodruffw added a commit to trail-of-forks/cryptography-old that referenced this pull request Aug 14, 2023

common: add more RSA-PSS algorithm id definitions

5ce560b

Breakout from pyca#9405. Signed-off-by: William Woodruff <[email protected]>

woodruffw mentioned this pull request Aug 14, 2023

common: add more RSA-PSS algorithm id definitions #9412

Merged

alex pushed a commit that referenced this pull request Aug 14, 2023

common: add more RSA-PSS algorithm id definitions (#9412)

c6d7bdf

Breakout from #9405. Signed-off-by: William Woodruff <[email protected]>

woodruffw added 4 commits August 14, 2023 20:59

Merge branch 'main' into tob-x509-api-breakout

f6933ca

Signed-off-by: William Woodruff <[email protected]>

tests: lintage

91ef5c4

Signed-off-by: William Woodruff <[email protected]>

src: lintage

fbe4132

Signed-off-by: William Woodruff <[email protected]>

Merge remote-tracking branch 'upstream/main' into tob-x509-api-breakout

2b46371

woodruffw mentioned this pull request Sep 6, 2023

x509/policy: add WebPKI permitted algorithms #9548

Merged

facutuesca and others added 3 commits September 7, 2023 15:24

Merge branch 'main' into tob-x509-api-breakout

1f5ee07

tests: fix linter warning

c96f4b8

policy: apply the relevant parts of trail-of-forks/cryptography/pull/3

5493338

Signed-off-by: William Woodruff <[email protected]>

woodruffw added 5 commits September 11, 2023 23:32

Merge branch 'main' into tob-x509-api-breakout

d900a6e

Signed-off-by: William Woodruff <[email protected]>

policy: typo

0789d73

Signed-off-by: William Woodruff <[email protected]>

fixup type hints

7852430

Signed-off-by: William Woodruff <[email protected]>

drop dep

a5154e1

Not used, yet. Signed-off-by: William Woodruff <[email protected]>

Revert "drop dep"

08df667

This reverts commit a5154e1.

woodruffw mentioned this pull request Sep 15, 2023

validation/ops: add test-only NullOps #9608

Closed

woodruffw added 10 commits September 15, 2023 20:01

policy: remove some verify-adjacent APIs

00d960e

Paring down for review. Signed-off-by: William Woodruff <[email protected]>

policy: remove more verify-adjacent APIs

03fb4b7

Signed-off-by: William Woodruff <[email protected]>

policy: remove some From impls

9ffbc9d

Signed-off-by: William Woodruff <[email protected]>

policy: remove rfc5280 constructor

ad90a81

Signed-off-by: William Woodruff <[email protected]>

docs: declutter diff

3610191

Signed-off-by: William Woodruff <[email protected]>

profile: prune even more state

05fb380

Signed-off-by: William Woodruff <[email protected]>

policy: remove old TODO

d0842ce

Signed-off-by: William Woodruff <[email protected]>

policy: remove PolicyError

924c749

For now. Signed-off-by: William Woodruff <[email protected]>

docs: typo

7cad491

Signed-off-by: William Woodruff <[email protected]>

ops: remove NullOps

92259c7

Signed-off-by: William Woodruff <[email protected]>

woodruffw changed the title ~~Path validation: builder and verifier APIs~~ Path validation: builder/verifier API skeletons Sep 15, 2023

alex reviewed Sep 16, 2023

View reviewed changes

woodruffw added 4 commits September 16, 2023 21:50

rust: remove dev-dep, don't use import

a5a88e6

Signed-off-by: William Woodruff <[email protected]>

rust: fix IP_ADDRESS rename

5e18f8e

Signed-off-by: William Woodruff <[email protected]>

docs: clarify time behavior

de2c7b0

Signed-off-by: William Woodruff <[email protected]>

rename webpki() to new()

a1a7c57

Since it doesn't actually do anything WebPKI related at the moment. Signed-off-by: William Woodruff <[email protected]>

woodruffw commented Sep 16, 2023

View reviewed changes

alex reviewed Sep 16, 2023

View reviewed changes

woodruffw added 3 commits September 16, 2023 22:22

docs: relocate

2e7bd70

Signed-off-by: William Woodruff <[email protected]>

verify: FixedPolicy -> PyCryptoPolicy

35f5e6f

Signed-off-by: William Woodruff <[email protected]>

verify: simplify SubjectOwner substantially

3c036bc

Signed-off-by: William Woodruff <[email protected]>

alex reviewed Sep 16, 2023

View reviewed changes

woodruffw added 2 commits September 16, 2023 22:46

verify: remove getter helper

fbb2e6a

Signed-off-by: William Woodruff <[email protected]>

verify: reloc TODO

0f91265

Signed-off-by: William Woodruff <[email protected]>

alex approved these changes Sep 16, 2023

View reviewed changes

alex enabled auto-merge (squash) September 16, 2023 20:47

alex merged commit 73d070e into pyca:main Sep 16, 2023
58 checks passed

woodruffw deleted the tob-x509-api-breakout branch September 16, 2023 20:57

woodruffw mentioned this pull request Sep 21, 2023

verification: fill in policy API internals #9642

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Path validation: builder/verifier API skeletons #9405

Path validation: builder/verifier API skeletons #9405

woodruffw commented Aug 11, 2023

alex commented Aug 14, 2023

woodruffw commented Aug 14, 2023

woodruffw commented Sep 8, 2023

woodruffw Sep 16, 2023

alex Sep 16, 2023

woodruffw Sep 16, 2023

alex Sep 16, 2023

woodruffw Sep 16, 2023

alex Sep 16, 2023

woodruffw Sep 16, 2023

alex Sep 16, 2023

alex Sep 16, 2023

woodruffw Sep 16, 2023

alex Sep 16, 2023

woodruffw Sep 16, 2023

woodruffw Sep 16, 2023

alex Sep 16, 2023

woodruffw Sep 16, 2023

		DNSName((pyo3::Py<pyo3::PyAny>, String)),
		IPAddress((pyo3::Py<pyo3::PyAny>, pyo3::Py<pyo3::types::PyBytes>)),

Path validation: builder/verifier API skeletons #9405

Path validation: builder/verifier API skeletons #9405

Conversation

woodruffw commented Aug 11, 2023

alex commented Aug 14, 2023

woodruffw commented Aug 14, 2023

woodruffw commented Sep 8, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment